Codecov Report

Merging #4943 into features will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           features    #4943      +/-   ##
============================================
+ Coverage     96.06%   96.06%   +<.01%     
============================================
  Files           114      114              
  Lines         25745    25741       -4     
  Branches       2548     2547       -1     
============================================
- Hits          24731    24728       -3     
  Misses          704      704              
+ Partials        310      309       -1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c9dcf1...08ded29. Read the comment docs.

Sorry for the delay!

Hmmm are you getting an error because of this code? We want to add a CHANGELOG error explaining in detail why we are reverting this code, and get a fix back quickly if this issue comes back.

Hmmm are you getting an error because of this code?

No, just found it confusing - likely when looking at coverage reports.

I'll add a changelog.

Maybe related to #4988.

Would you like to include this one in 4.4 @blueyed?

Rather not.. too much in there already.. ;)

Gentle ping in case you want to pick this up again. 👍

Added changelog, and rebased it.

I noticed you added this to the 5.0 milestone, is that correct?

Yes, before - but only since it was the next after 4.4.

OK to move to 4.5 then?

Sure, I'd just merge it already.