logging: improve default logging format (issue5214)#5227
Conversation
|
Tests are failing on the filename of the changelog file added. Shall I rename that to |
nicoddemus
left a comment
There was a problem hiding this comment.
Hey @Pulkit07,
Thanks a ton for your contribution, we greatly appreciate it!
As this is changing an existing behavior, this should go into the features branch, so please rebase on top of features. 👍
Also please take a look at my comments and let me know what you think.
|
Thanks already!
You can force-push here, and then change the target branch at the top next to the PR title. While at it, please also edit the commit message (i.e. remove speculation about having a changelog from there).. :) |
Codecov Report
@@ Coverage Diff @@
## features #5227 +/- ##
===========================================
- Coverage 96.13% 94.63% -1.5%
===========================================
Files 115 115
Lines 26040 26040
Branches 2568 2568
===========================================
- Hits 25033 24643 -390
- Misses 706 1080 +374
- Partials 301 317 +16
Continue to review full report at Codecov.
|
We improve the following things in the logging format: * Show module name instead of just the filename * show level of logging as the first thing * show lineno attached to module:file details Thanks to @blueyed who suggested this on the github issue. It's my first contribution and I have added myself to AUTHORS. I also added to a changelog file.
|
Hey @nicoddemus and @blueyed, thanks for such a quick review. |
nicoddemus
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot @Pulkit07 for the contribution! 👍
Thanks to you too. Do you have any starter bug in mind which I can work on? Also, I am unable to find some mention about IRC channel or gitter or something where discussions related to pytest happen. Most probably I missed something. Can you help me pointing at any such channel which I can join and take help in resolving future issues? |
|
You have not changed the commit message (try While it would be ok, I got like a lot of notifications due to me being mentioned therein, and I'd rather not get more of them - i.e. it is usually a bad idea to mention somebody in commit messages. |
|
btw: normally you could just edit/remove this when squash-merging, but other maintainers do not like it unfortunately. |
We improve the following things in the logging format:
Thanks to @blueyed who suggested this on the github issue.
It's my first contribution and I have added myself to AUTHORS.
I also added to a changelog file.
Fix #5214
changelogfolder, with a name like<ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.masterbranch for bug fixes, documentation updates and trivial changes.featuresbranch for new features and removals/deprecations.Unless your change is trivial or a small documentation fix (e.g., a typo or reword of a small section) please:
AUTHORSin alphabetical order;