Use sphinx removed in extension in the documentation#4570
Conversation
feca6cf to
fe01b9e
Compare
Codecov Report
@@ Coverage Diff @@
## features #4570 +/- ##
============================================
- Coverage 95.75% 95.73% -0.02%
============================================
Files 111 111
Lines 24671 24671
Branches 2445 2445
============================================
- Hits 23623 23620 -3
Misses 740 740
- Partials 308 311 +3
Continue to review full report at Codecov.
|
|
Hmmm same error even though MrSenko/sphinx-removed-in#1 has been fixed and we are using |
|
@nicoddemus setup_requires happens too late to work out sanely there, aka its evaluated after that import happens |
|
Duh of course. I suppose the simplest fix would be to stop importing cc @MrSenko |
Follow up to MrSenko#1: unfortunately `setup_requires` is not enough to fix the original issue, as `setup_requires` can't be evaluated yet (ref: pytest-dev/pytest#4570 (comment)).
Follow up to #1: unfortunately `setup_requires` is not enough to fix the original issue, as `setup_requires` can't be evaluated yet (ref: pytest-dev/pytest#4570 (comment)).
fe01b9e to
81c2780
Compare
|
|
||
| This has been documented as deprecated for years, but only now we are actually emitting deprecation warnings. | ||
|
|
||
| ``Node.get_marker`` |
There was a problem hiding this comment.
Moved those two deprecations to near the other ones from 4.0.
| pygments-pytest>=1.1.0 | ||
| sphinx>=1.8.2 | ||
| sphinxcontrib-trio | ||
| sphinx-removed-in>=0.1.3 |
|
Ready for review. 👍 |
|
Is there a way to see the compiled docs online for the review? (other than checking it out and building locally that is) |
|
@nicoddemus can we push this branch to the main repo so we can trigger a rtd build? |
|
Hmm I did a few hours ago and I still don't see it listed under the "versions" option. Weird. 🤔 |
|
Ahh there you go: https://docs.pytest.org/en/sphinx-removed-in/deprecations.html |
|
Targetting |
|
@Tadaboody gentle ping. 😁 |
Fix #4568
This is blocked by MrSenko/sphinx-removed-in#1: