Do not import sphinx at top level of sphinx_removed_in#2
Merged
Conversation
Follow up to MrSenko#1: unfortunately `setup_requires` is not enough to fix the original issue, as `setup_requires` can't be evaluated yet (ref: pytest-dev/pytest#4570 (comment)).
atodorov
requested changes
Dec 20, 2018
atodorov
left a comment
Contributor
There was a problem hiding this comment.
Looks good but make sure to fix flake8 and make Travis CI happy.
Contributor
Author
|
Sure, fixed! 😁 |
atodorov
approved these changes
Dec 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #1: unfortunately
setup_requiresis not enough to fix the original issue, assetup_requirescan't be evaluated at that point yet (ref: pytest-dev/pytest#4570 (comment)).