Skip to content

Fixes incorrect default value for scale parameter in makeARGB.#793

Merged
j9ac9k merged 2 commits intopyqtgraph:developfrom
titusjan:develop
Aug 18, 2019
Merged

Fixes incorrect default value for scale parameter in makeARGB.#793
j9ac9k merged 2 commits intopyqtgraph:developfrom
titusjan:develop

Conversation

@titusjan
Copy link
Copy Markdown
Contributor

@titusjan titusjan commented Dec 2, 2018

Fixes issue #792

@j9ac9k j9ac9k added this to the 0.11 milestone Jun 26, 2019
@j9ac9k j9ac9k self-assigned this Jun 26, 2019
@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Jun 27, 2019

CI fails on this PR as it currently stands:

https://dev.azure.com/pyqtgraph/pyqtgraph/_build/results?buildId=259

@campagnola
Copy link
Copy Markdown
Member

Looks good to me; I agree with @titusjan's assessment in #792. Unit tests in pyqtgraph/tests/test_functions.py : test_makeARGB() will need to be updated to reflect the change, and we definitely want a CHANGELOG entry noting the behavior change.

@Dschoni
Copy link
Copy Markdown
Contributor

Dschoni commented Jul 30, 2019

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Aug 18, 2019

I fixed the test cases so they now pass; not exactly sure what should be stated in CHANGELOG specifically. I'm going to leave the CHANGELOG update to be handled by #1005

All the CI failures are conda/conda-forge related issues, and a fix is pending in PR #991

I'll merge this when the CI run is finished given that @campagnola has already given this code change his blessing

@j9ac9k j9ac9k merged commit 3a863ff into pyqtgraph:develop Aug 18, 2019
@titusjan
Copy link
Copy Markdown
Contributor Author

Sorry for my lack of response on this and thanks for fixing the tests.

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Aug 18, 2019

Don't sweat it, thanks for the PR and the analysis you did in #792

@Dschoni
Copy link
Copy Markdown
Contributor

Dschoni commented Aug 19, 2019

Does that indeed fix #792? As it is still open. If so, I would put exactly that in CHANGELOG.

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Aug 19, 2019

Yeah I meant to close it, my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants