Conversation
|
Added |
|
Started working on this on another branch, the flake8 -diff checks are still tough to integrate at the commit time. I am not a fan of having this check strictly in the CI (this takes too long to hear back that you have an extra space, or your line is too long). I've created https://github.com/pyqtgraph/pre-commit-hooks and have been trying too make a hook to run the flake8 diff, but so far I haven't been able to get it working as I intended. If anyone has any suggestions on how to integrate that check at commit time, let me know. |
|
ugh....what on earth is happening w/ creating conda environments in the CI process? |
d75dcf9 to
24cba27
Compare
|
something has changed on azure pipelines with respect to how macOS and conda task work; this will take be a little while to debug. |
edd2300 to
b1a4504
Compare
1c232f7 to
e2281b6
Compare
|
Gave up on trying to get linting checks to happen at the pre-commit time (doing a flake8 check on a file basis is fine, but doing it on the I had to modify the CI script substantially for a few reasons
|
|
Throwing WIP label as i realized i never actually tested the 100kb size limit on the size check...will want to do that before this is merged, I'll test on another branch |
|
Cleaned up the PR, I think this is ready for review; only thing I couldn't do is get the |
campagnola
left a comment
There was a problem hiding this comment.
Looks great to me! Thanks @j9ac9k !
|
Thanks @campagnola I'll go ahead and merge as you gave approval Thanks for everyone's patience with me on this,...this took me way too long to sort out, and there will likely be changes coming in the future with pytest-nunit, updates to pyqtgraph-core and doc builds. |
Current azure-pipelines only does unit-testing on the 18 configurations we have set. With this pull request, azure-pipelines does more checks in line with the
extraflag on used in Travis CI.To be more specific, azure-pipelines now has multiple stages,
pre-testandtest. During thepre-teststage, the following things happen in parallelpython.setup.py styleis runDuring the
teststage, all the unit tests run as before, with the exception that they download the bdist_wheel artifact and install that (so instead of creating 18 wheels and installing each one for on its own pipeline, we create one wheel, and use that wheel for all 18 pipelines)The latest build can be seen here:
https://dev.azure.com/j9ac9k/pyqtgraph-fork/_build/results?buildId=284
In addition, this PR includes a few other features
.flake8file is added to better support flake8 integration with editors andpre-commit.pre-commit-config.ymlis added allowing for support forpre-commitchecks to run at commit time.A note about
pre-commitis added toCONTRIBUTING.md; it is strictly optional, however it will be helpful for ensuring code passes quality checks at commit time.Also some changes were made to some files with diffs to make them conform to the new flake8 checks that are run against the CI.