Trying to add support for roiCurves with multi-color image stacks in ImageView#312
Trying to add support for roiCurves with multi-color image stacks in ImageView#312ptweir wants to merge 5 commits intopyqtgraph:developfrom
Conversation
|
Thanks for the PR @ptweir ! Could you add an example in https://github.com/pyqtgraph/pyqtgraph/tree/develop/examples that demonstrates this usage? Seeing it in action would help evaluate the PR |
|
Hi @ericdill thanks for the suggestion. Let me know how to improve the example and/or changes. (I've included an example script based on the ImageView.py example script.) |
|
It turns out |
|
@j9ac9k yeah the example works with the current state of |
* work taken from pyqtgraph#312 (thanks, @ptweir !) * turn on an ROI by default
|
I took @ixjlyons' thought and ran with it; this PR has a funner example than the original, so I say we just use the example here. I'm closing this PR so I can just merge that example file change. [ Edited to have fewer ambiguous pronouns ] |
roiCurve is replaced by a list, roiCurves. When an roi is changed in a 4-dimensional image stack, an roiCurve is added for each color.
*I apologize in advance if these changes are undesirable. (This is my first time submitting a pull request on an open source project.)