Skip to content

Trying to add support for roiCurves with multi-color image stacks in ImageView#312

Closed
ptweir wants to merge 5 commits intopyqtgraph:developfrom
ptweir:develop
Closed

Trying to add support for roiCurves with multi-color image stacks in ImageView#312
ptweir wants to merge 5 commits intopyqtgraph:developfrom
ptweir:develop

Conversation

@ptweir
Copy link
Copy Markdown

@ptweir ptweir commented Apr 13, 2016

roiCurve is replaced by a list, roiCurves. When an roi is changed in a 4-dimensional image stack, an roiCurve is added for each color.

*I apologize in advance if these changes are undesirable. (This is my first time submitting a pull request on an open source project.)

@ericdill
Copy link
Copy Markdown
Contributor

Thanks for the PR @ptweir ! Could you add an example in https://github.com/pyqtgraph/pyqtgraph/tree/develop/examples that demonstrates this usage? Seeing it in action would help evaluate the PR

@ptweir
Copy link
Copy Markdown
Author

ptweir commented Apr 15, 2016

Hi @ericdill thanks for the suggestion. Let me know how to improve the example and/or changes. (I've included an example script based on the ImageView.py example script.)

@j9ac9k j9ac9k added the ROI Relating to Region of Interest Changes label Jun 14, 2020
@ixjlyons ixjlyons self-assigned this Jul 7, 2020
@ixjlyons
Copy link
Copy Markdown
Member

ixjlyons commented Jul 7, 2020

It turns out ImageView has sort of independently evolved to support ROI average curves for each color channel (4a4a738), including stacked color images, so this example just works (once #1291 is merged). Making a note here that we should cherry-pick f5c4eee because that's a pretty cool example that really demonstrates what's going on.

@j9ac9k
Copy link
Copy Markdown
Member

j9ac9k commented Jan 4, 2021

@ixjlyons just saw your comment (why am I so bad at this); you suggesting either updating this PR (or creating a new PR) with just f5c4eee and things will "just work"?

@ptweir sorry this PR has sat idle for so long, we've had quite the PR back-log which I've made a priority to go through.

@ixjlyons
Copy link
Copy Markdown
Member

@j9ac9k yeah the example works with the current state of ImageView without further modification. My suggestion was to just grab this example script then add it to the example app. I started doing it and waffled on it because I'm not sure it makes sense to have both examples/ImageView.py and this one. Maybe they should just be merged.

outofculture added a commit to outofculture/pyqtgraph that referenced this pull request Feb 25, 2021
* work taken from pyqtgraph#312 (thanks, @ptweir !)
* turn on an ROI by default
@outofculture
Copy link
Copy Markdown
Contributor

outofculture commented Feb 25, 2021

I took @ixjlyons' thought and ran with it; this PR has a funner example than the original, so I say we just use the example here. I'm closing this PR so I can just merge that example file change.

[ Edited to have fewer ambiguous pronouns ]

outofculture added a commit that referenced this pull request Feb 26, 2021
* work taken from #312 (thanks, @ptweir !)
* turn on an ROI by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ROI Relating to Region of Interest Changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants