Get ImageView ROI working with both row and col major data#1291
Merged
j9ac9k merged 1 commit intopyqtgraph:masterfrom Jul 7, 2020
Merged
Get ImageView ROI working with both row and col major data#1291j9ac9k merged 1 commit intopyqtgraph:masterfrom
j9ac9k merged 1 commit intopyqtgraph:masterfrom
Conversation
ixjlyons
commented
Jul 5, 2020
| else: | ||
| # Average data within entire ROI for each frame | ||
| data = data.mean(axis=max(axes)).mean(axis=min(axes)) | ||
| data = data.mean(axis=axes) |
Member
Author
There was a problem hiding this comment.
I should mention this works for numpy >= 1.7.0 (Feb. 2013), minimum in setup.py is 1.8.0
Member
|
LGTM, thanks for fixing this @ixjlyons ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1280. The comment here is implemented, plus there was a bug in the region averaging for the single-image case. Now the selection is averaged along the y axis of the ROI in both row-major and col-major cases (x axis of the
PlotItemshould correspond to the x axis of the ROI).Script I used for testing (along with
examples/ImageView.pyfor testing an image stack):