Use a JS Type Reflection based trampoline if possible#3955
Closed
hoodmane wants to merge 6 commits intopyodide:mainfrom
Closed
Use a JS Type Reflection based trampoline if possible#3955hoodmane wants to merge 6 commits intopyodide:mainfrom
hoodmane wants to merge 6 commits intopyodide:mainfrom
Conversation
This is split off from pyodide#3210
for more information, see https://pre-commit.ci
…able When type reflection is available, this uses an alternate trampoline that inspects how many arguments the function actually needs and then chooses the appropriate call with a switch block. This is necessary to use JSPI because it does not interact well with trampolines
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jun 28, 2023
This is a replacement for pyodide#3954 and pyodide#3955 structured as an upstream patch
Member
Author
|
Closed in favor of #3964 |
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 7, 2023
This is a replacement for pyodide#3954 and pyodide#3955 structured as an upstream patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split off from #3210 and on top of #3954.
When type reflection is available, this uses an alternate trampoline that
inspects how many arguments the function actually needs and then chooses the
appropriate call with a switch block. This is necessary to use JSPI because
it does not interact well with trampolines.
This code will be used on Chrome and Safari but not Firefox. As far as I can tell it's
performance neutral.