move trampolines from cpython source into Pyodide source#3954
Closed
hoodmane wants to merge 9 commits intopyodide:mainfrom
Closed
move trampolines from cpython source into Pyodide source#3954hoodmane wants to merge 9 commits intopyodide:mainfrom
hoodmane wants to merge 9 commits intopyodide:mainfrom
Conversation
This is split off from pyodide#3210
for more information, see https://pre-commit.ci
This was referenced Jun 24, 2023
Merged
Member
Author
|
@ryanking13 @rth I think this one should be reviewed/merged first. Hopefully it isn't too complicated, it just moves some logic from the cpython source into Pyodide. |
ryanking13
approved these changes
Jun 28, 2023
Member
ryanking13
left a comment
There was a problem hiding this comment.
Thanks, @hoodmane, and sorry for the late review. I have a few comments, otherwise LGTM.
Member
There was a problem hiding this comment.
Note to myself: this patch is applied to unvendored test module.
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jun 28, 2023
This is a replacement for pyodide#3954 and pyodide#3955 structured as an upstream patch
Member
Author
|
Closed in favor of #3964 |
hoodmane
added a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 7, 2023
This is a replacement for pyodide#3954 and pyodide#3955 structured as an upstream patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is split off from #3210.
We need to change the way the Python trampolines work for #3210. This does the first step of moving the definitions into our own code.
#3955 is on top of this and it changes the definition to the one we need for jspi.