BUG: Use the correct name StandardEncoding for the predefined cmap#3156
Merged
stefan6419846 merged 3 commits intopy-pdf:mainfrom Feb 26, 2025
Merged
BUG: Use the correct name StandardEncoding for the predefined cmap#3156stefan6419846 merged 3 commits intopy-pdf:mainfrom
stefan6419846 merged 3 commits intopy-pdf:mainfrom
Conversation
Collaborator
Author
|
I still need to have a look at getting hold of an actual test file to share publicly before merging this. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3156 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 53 53
Lines 8903 8903
Branches 1631 1631
=======================================
Hits 8594 8594
Misses 185 185
Partials 124 124 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Example file: standard-encoding.pdf |
stefan6419846
added a commit
that referenced
this pull request
Mar 2, 2025
## What's new ### Bug Fixes (BUG) - Use the correct name StandardEncoding for the predefined cmap (#3156) by @stefan6419846 - Handle inline images containing `EI ` sequences (#3152) by @stefan6419846 - Fix check box value which should be name object (#3124) by @stefan6419846 - Fix stream position on inline image fallback extraction (#3120) by @stefan6419846 - Fix object count for incremental writer (#3117) by @m32 ### Robustness (ROB) - Avoid index errors on empty lines in xref table (#3162) by @stefan6419846 - Improve handling of LZW decoder table overflow (#3159) by @stefan6419846 - Ignore non-numbers for width when building font width map (#3158) by @stefan6419846 - Avoid negative seek values when reading partially broken files (#3157) by @stefan6419846 ### Documentation (DOC) - Fixed PageObject.images example usage for replacing image (#3149) by @jutoth [Full Changelog](5.3.0...5.3.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, running text extraction on specific PDF files would state:
This has always been surprising to me, until I finally found enough time to further debug this. Turns out that #924 introduced the wrong name
StandardCodinginstead ofStandardEncodingfor the predefined cmaps.StandardCodingis not part of the PDF specification, whileStandardEncodingis indeed (for example in Annex D of the PDF 2.0 specification). As this encoding is the default encoding for undefined names, this would not have any side effects on the actual text extraction results.