Skip to content

BUG: Fix check box value which should be name object#3124

Merged
stefan6419846 merged 1 commit intopy-pdf:mainfrom
stefan6419846:issue3115-checkbox
Feb 14, 2025
Merged

BUG: Fix check box value which should be name object#3124
stefan6419846 merged 1 commit intopy-pdf:mainfrom
stefan6419846:issue3115-checkbox

Conversation

@stefan6419846
Copy link
Copy Markdown
Collaborator

Relates to #3115.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.51%. Comparing base (1c3baab) to head (a334b3f).
Report is 109 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3124   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          53       53           
  Lines        8871     8876    +5     
  Branches     1622     1622           
=======================================
+ Hits         8562     8567    +5     
  Misses        185      185           
  Partials      124      124           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846 stefan6419846 merged commit 75a6003 into py-pdf:main Feb 14, 2025
16 checks passed
@stefan6419846 stefan6419846 deleted the issue3115-checkbox branch February 14, 2025 11:33
stefan6419846 added a commit that referenced this pull request Mar 2, 2025
## What's new

### Bug Fixes (BUG)
- Use the correct name StandardEncoding for the predefined cmap (#3156) by @stefan6419846
- Handle inline images containing `EI ` sequences (#3152) by @stefan6419846
- Fix check box value which should be name object (#3124) by @stefan6419846
- Fix stream position on inline image fallback extraction (#3120) by @stefan6419846
- Fix object count for incremental writer (#3117) by @m32

### Robustness (ROB)
- Avoid index errors on empty lines in xref table (#3162) by @stefan6419846
- Improve handling of LZW decoder table overflow (#3159) by @stefan6419846
- Ignore non-numbers for width when building font width map (#3158) by @stefan6419846
- Avoid negative seek values when reading partially broken files (#3157) by @stefan6419846

### Documentation (DOC)
- Fixed PageObject.images example usage for replacing image (#3149) by @jutoth

[Full Changelog](5.3.0...5.3.1)
stefan6419846 added a commit to stefan6419846/pypdf that referenced this pull request Dec 31, 2025
This fixes the first part of py-pdf#3549, where py-pdf#3124 was incorrect without me
noticing this. To avoid this in the future, add a more complex test
actually covering the exact form values and checking the value of the
`/V` key for its type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant