ROB: MissingWidth is IndirectObject#2288
Merged
MartinThoma merged 3 commits intomainfrom Nov 14, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2288 +/- ##
==========================================
- Coverage 94.45% 94.39% -0.07%
==========================================
Files 43 43
Lines 7651 7654 +3
Branches 1511 1513 +2
==========================================
- Hits 7227 7225 -2
- Misses 262 266 +4
- Partials 162 163 +1 ☔ View full report in Codecov by Sentry. |
pubpub-zz
reviewed
Nov 9, 2023
Collaborator
pubpub-zz
left a comment
There was a problem hiding this comment.
NullObject should also be considered
Co-authored-by: pubpub-zz <4083478+pubpub-zz@users.noreply.github.com>
Co-authored-by: pubpub-zz <4083478+pubpub-zz@users.noreply.github.com>
Member
Author
|
@pubpub-zz Thank you! I really hope that we find a more principal way to deal with those kinds of issues some day. Pretty much every PDF attribute might be missing / indirect / NullObject, even if the standard does not allow it. |
MartinThoma
added a commit
that referenced
this pull request
Nov 14, 2023
## What's new ### Bug Fixes (BUG) - Mediabox expansion size when applying non-right angle rotation (#2282) by @MrinalJain17 ### Robustness (ROB) - MissingWidth is IndirectObject (#2288) by @MartinThoma - Initialize states array with an empty value (#2280) by @alexey-v-paramonov ### Documentation (DOC) - Typo in example in extract-attachments.md (#2285) by @ageitgey - Add Alexey Paramonov as a contributor for #2280 by @MartinThoma ### Maintenance (MAINT) - Update sample-files by @MartinThoma [Full Changelog](3.17.0...3.17.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2286