DOC: Fix typo in example in extract-attachments.md#2285
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Nov 14, 2023
Merged
DOC: Fix typo in example in extract-attachments.md#2285MartinThoma merged 1 commit intopy-pdf:mainfrom
MartinThoma merged 1 commit intopy-pdf:mainfrom
Conversation
Member
|
Thank you! If you want, I can add you to https://pypdf.readthedocs.io/en/latest/meta/CONTRIBUTORS.html |
MartinThoma
added a commit
that referenced
this pull request
Nov 14, 2023
## What's new ### Bug Fixes (BUG) - Mediabox expansion size when applying non-right angle rotation (#2282) by @MrinalJain17 ### Robustness (ROB) - MissingWidth is IndirectObject (#2288) by @MartinThoma - Initialize states array with an empty value (#2280) by @alexey-v-paramonov ### Documentation (DOC) - Typo in example in extract-attachments.md (#2285) by @ageitgey - Add Alexey Paramonov as a contributor for #2280 by @MartinThoma ### Maintenance (MAINT) - Update sample-files by @MartinThoma [Full Changelog](3.17.0...3.17.1)
Contributor
Author
|
@MartinThoma Thanks for the great library - it saved me a lot of work. No need to give me any credit just for fixing a DOC typo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example code in
extract-attachments.mditerates over a dictionary but doesn't properly call.items(), so the code fails as written. This adds the.items()call so the example works if cut and pasted into python.