BUG: Fix dictionary access of optional page label keys#1562
Merged
MartinThoma merged 2 commits intomainfrom Jan 18, 2023
Merged
BUG: Fix dictionary access of optional page label keys#1562MartinThoma merged 2 commits intomainfrom
MartinThoma merged 2 commits intomainfrom
Conversation
Fixes #1560 Co-authored-by: jonahmajumder <jmajumder9@gmail.com>
Codecov ReportBase: 91.86% // Head: 91.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1562 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 33 33
Lines 6122 6124 +2
Branches 1208 1208
=======================================
+ Hits 5624 5626 +2
Misses 322 322
Partials 176 176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pubpub-zz
reviewed
Jan 18, 2023
Contributor
|
@pubpub-zz I was about to point that out. Otherwise looks good to me. Thanks. |
Co-authored-by: pubpub-zz <4083478+pubpub-zz@users.noreply.github.com>
Member
Author
|
Thank you both for the review! |
MartinThoma
added a commit
that referenced
this pull request
Jan 22, 2023
New Features (ENH): - Add page label support to PdfWriter (#1558) - Accept inline images with space before EI (#1552) - Add circle annotation support (#1556) - Add polygon annotation support (#1557) - Make merging pages produce a deterministic PDF (#1542, #1543) Bug Fixes (BUG): - Fix error in cmap extraction (#1544) - Remove erroneous assertion check (#1564) - Fix dictionary access of optional page label keys (#1562) Robustness (ROB): - Set ignore_eof=True for read_until_regex (#1521) Documentation (DOC): - Paper size (#1550) Developer Experience (DEV): - Fix broken combination of dependencies of docs.txt - Annotate tests appropriately (#1551) [Full Changelog](3.2.1...3.3.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1560
TODO
Add a (minimal) test which shows this issue. Maybe we can adjust
resources/pdflatex-outline.pdf?