Merged
Conversation
MartinThoma
reviewed
Jan 14, 2023
pypdf/papersizes.py
Outdated
| A6 = Dimensions(298, 420) # Post cards | ||
| A7 = Dimensions(210, 298) | ||
| A8 = Dimensions(147, 210) | ||
|
|
Member
There was a problem hiding this comment.
If you undo the changes in this file, we can merge it (you can just apply black and make another commit)
Contributor
Author
There was a problem hiding this comment.
I have undone the changes to the file and pushed them onto the fork. Is there anything else I may need to do?
Member
|
Thank you for the PR 🤗 |
MartinThoma
added a commit
that referenced
this pull request
Jan 22, 2023
New Features (ENH): - Add page label support to PdfWriter (#1558) - Accept inline images with space before EI (#1552) - Add circle annotation support (#1556) - Add polygon annotation support (#1557) - Make merging pages produce a deterministic PDF (#1542, #1543) Bug Fixes (BUG): - Fix error in cmap extraction (#1544) - Remove erroneous assertion check (#1564) - Fix dictionary access of optional page label keys (#1562) Robustness (ROB): - Set ignore_eof=True for read_until_regex (#1521) Documentation (DOC): - Paper size (#1550) Developer Experience (DEV): - Fix broken combination of dependencies of docs.txt - Annotate tests appropriately (#1551) [Full Changelog](3.2.1...3.3.0)
Contributor
|
@MartinThoma @SandroPanchame the examples contain |
Member
|
Thank you @xilopaint - #1573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added examples on how to use the PaperSize class.
I'm not sure what went wrong with the last request.