ROB : cope with invalid parent xref (#1089)#1133
Merged
MartinThoma merged 1 commit intopy-pdf:mainfrom Jul 20, 2022
Merged
Conversation
rebuild the xref if the parent chained xref is invalid
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 92.03% 91.94% -0.10%
==========================================
Files 24 24
Lines 4671 4679 +8
Branches 965 966 +1
==========================================
+ Hits 4299 4302 +3
- Misses 227 231 +4
- Partials 145 146 +1
Continue to review full report at Codecov.
|
Member
|
Oh yes! Nice! I love that we're now capable of dealing with that issue 🥳 Thank you, @pubpub-zz 🤗 |
MartinThoma
added a commit
that referenced
this pull request
Jul 21, 2022
New Features (ENH): - Add `outline_count` property (#1129) Bug Fixes (BUG): - Make reader.get_fields also return dropdowns with options (#1114) - Add deprecated EncodedStreamObject functions back until PyPDF2==3.0.0 (#1139) Robustness (ROB): - Cope with missing /W entry (#1136) - Cope with invalid parent xref (#1133) Documentation (DOC): - Contributors file (#1132) - Fix type in signature of PdfWriter.add_uri (#1131) Developer Experience (DEV): - Add .git-blame-ignore-revs (#1141) Code Style (STY): - Fixing typos (#1137) - Re-use code via get_outlines_property in tests (#1130) Full Changelog: 2.6.0...2.7.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuild the xref if the parent chained xref is invalid