Skip to content

ENH: add outline_count property#1129

Merged
MartinThoma merged 2 commits intopy-pdf:mainfrom
mtd91429:outline_count
Jul 18, 2022
Merged

ENH: add outline_count property#1129
MartinThoma merged 2 commits intopy-pdf:mainfrom
mtd91429:outline_count

Conversation

@mtd91429
Copy link
Copy Markdown
Contributor

@mtd91429 mtd91429 commented Jul 17, 2022

Enables retrieval of "/Count" attribute of outline item in PdfReader by implementing property outline_count. Addresses #1122

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2022 •
edited
Loading

Codecov Report

Merging #1129 (e2b46d7) into main (33634d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1129   +/-   ##
=======================================
  Coverage   92.02%   92.03%           
=======================================
  Files          24       24           
  Lines        4666     4671    +5     
  Branches      964      965    +1     
=======================================
+ Hits         4294     4299    +5     
  Misses        227      227           
  Partials      145      145
Impacted Files Coverage Δ
PyPDF2/_reader.py 91.48% <100.00%> (+0.02%) ⬆️
PyPDF2/generic.py 91.72% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33634d4...e2b46d7. Read the comment docs.

@MartinThoma MartinThoma merged commit 25cba33 into py-pdf:main Jul 18, 2022
@MartinThoma
Copy link
Copy Markdown
Member

MartinThoma commented Jul 18, 2022

Thank you for the nice PR and the detailed issue description 🤗

I absolutely love such PRs 😍

(1) Purpose: Due to the issue, I know the desired outcome / why the PR was made
(2) Focus: The PR is only about this part, so I only need to decide if that goal was reached and if the code is in a reasonable state
(3) Tests: The test means I don't need to add other work it it - the test already shows that it works as desired

Very well done 👍

MartinThoma added a commit that referenced this pull request Jul 21, 2022
@MartinThoma
REL: 2.7.0
6899c74 
New Features (ENH):
-  Add `outline_count` property (#1129)

Bug Fixes (BUG):
-  Make reader.get_fields also return dropdowns with options (#1114)
-  Add deprecated EncodedStreamObject functions back until PyPDF2==3.0.0 (#1139)

Robustness (ROB):
-  Cope with missing /W entry (#1136)
-  Cope with invalid parent xref (#1133)

Documentation (DOC):
-  Contributors file (#1132)
-  Fix type in signature of PdfWriter.add_uri (#1131)

Developer Experience (DEV):
-  Add .git-blame-ignore-revs (#1141)

Code Style (STY):
-  Fixing typos (#1137)
-  Re-use code via get_outlines_property in tests (#1130)

Full Changelog: 2.6.0...2.7.0
@mtd91429 mtd91429 deleted the outline_count branch August 1, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtd91429 @MartinThoma