fix: source _pure_prompt_new_line event handler instead of relying on autoloading#357
Merged
edouard-lopez merged 1 commit intomasterfrom May 19, 2025
Merged
Conversation
Member
Author
|
Test are silently failing |
|
Seems to do the trick! There is a space now after the output of a command Although it doesn't have space above the initial prompt, seems to be fine after |
Member
Author
|
I'm using Tmux which might differ from what you have, could you share a screenshot? |
|
Any update? |
… autoloading From the doc: https://fishshell.com/docs/current/language.html#event > Please note that event handlers only become active when a function is loaded, > which means you need to otherwise source or execute a function instead of > relying on autoloading. fix #356
Member
Author
|
I'm rebasing and merging as the initial issue was fixed. |
215acb1 to
159e0b6
Compare
|
This broke on NixOS for me. Reported in nixpkgs: NixOS/nixpkgs#408917 (comment) |
edouard-lopez
added a commit
that referenced
this pull request
May 27, 2025
…ry too related: fix: source _pure_prompt_new_line event handler instead of relying on autoloading #357
14 tasks
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


related: fixes #356
From the doc: https://fishshell.com/docs/current/language.html#event
TODO
How to test pre-release?
fisher install pure-fish/pure@fix/no-line-spacing-between-prompts-356 # branch nameSpecs
Documentation
Event handlers aren't autoloaded, so we need to force loading of the
_pure_prompt_new_linehandler in the init process.Acceptance Checks
conf.d/pure.fishfor:tests/feature_name.test.fish;