fix(nixOS): use relative path resolution so it work in vendor directory too#371
Merged
edouard-lopez merged 1 commit intomasterfrom Jun 6, 2025
Conversation
a37b653 to
4ca6ee3
Compare
15 tasks
b82f200 to
baaf886
Compare
|
It doesn't work for me: NixOS is very weird. It's symlinks all the way down. If you want to test yourself, you can create a {pkgs ? import <nixpkgs> {}}:
pkgs.mkShell {
packages = [
pkgs.fish
(pkgs.fishPlugins.buildFishPlugin {
pname = "pure";
version = "4.11.2";
src = pkgs.fetchFromGitHub {
owner = "pure-fish";
repo = "pure";
rev = "4ca6ee33df9bb0a6b1a1800b96acc1cb3a64f324";
hash = "sha256-UezBDdcd0Ku5wpZLsTXCRnDNejoJKt+JFtpeOcxgWmo=";
};
})
];
}And then, with podman or docker: After pushing a new commit, change the Change the There is surely a way to do it all locally, but I'm not sure how -- this way you will mirror exactly how the NixOS package is built. |
Member
Author
|
Thanks for the detailed message! I see there is a I've a docker to test on NixOS that use can use through the |
|
It is not uncommon for programs to be patched as part of the packaging process for NixOS, rather than rely on upstream, since it is so different from other distros. Perhaps the maintainer of the package, @pacien can help. |
4ca6ee3 to
390570f
Compare
390570f to
0649346
Compare
3 tasks
Member
Author
|
I found a fix using your |
|
That seems to work! 🎉 |
dba2183 to
0649346
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related:
How to test pre-release?
First contribution?
Check the 👍 contributing guide for code and naming conventions.
Specs
Documentation
Usage
Installing this version on NixOS should succeed without error
Acceptance Checks
conf.d/pure.fishfor:tests/feature_name.test.fish;