Skip to content

Fix ts->proptype script#2

Merged
pugnascotia merged 1 commit intopugnascotia:migrate-all-the-ts-thingsfrom
chandlerprall:pull/2212
Aug 12, 2019
Merged

Fix ts->proptype script#2
pugnascotia merged 1 commit intopugnascotia:migrate-all-the-ts-thingsfrom
chandlerprall:pull/2212

Conversation

@chandlerprall
Copy link
Copy Markdown

Updates the ts->proptype script to support the changes made in elastic#2212

  1. doesn't double-inject import PropTypes from 'prop-types' statement (throws an error when generating new code, blocked build)
  2. allow circular dependencies in ts/tsx files (threw the build into an infinite loop :all-the-cpu-cycles:)

I can yarn build and run the dev docs server with these changes.

@pugnascotia pugnascotia merged commit 9ae0ecb into pugnascotia:migrate-all-the-ts-things Aug 12, 2019
pugnascotia pushed a commit that referenced this pull request Aug 23, 2019
pugnascotia pushed a commit that referenced this pull request Mar 23, 2020
* fixed errors

* updated changelog

* Update CHANGELOG.md

* added preview in docs-section

* Update CHANGELOG.md

* added example file

* Fixing anchor and disabled styles, updating example (#2)

Thanks @cchaos

* added tests

* Update CHANGELOG.md

Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants