now EuiBadge render anchor tags too#3009
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cchaos
left a comment
There was a problem hiding this comment.
@anishagg17 We will also need a new docs section below Badge with onClick events that is Badge with href. Can you start this docs page and we'll help flesh out the content?
|
Okay @cchaos |
|
@cchaos as button-badge which was disabled was also not listed. So, I added it too in this pr |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3009/ |
cchaos
left a comment
There was a problem hiding this comment.
This is an example of why we document or show examples of permutations of components. To find rendering issues like having a link inside a badge.
There's quite a bit of styling fixes needed for this one that will require a designer's touch. So I'll get you PR later today.
|
@anishagg17 I created a PR for you: anishagg17#2 You will also need to add tests for the |
|
Jenkins, test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3009/ |
cchaos
left a comment
There was a problem hiding this comment.
LGTM, but I'd like @chandlerprall's review for TS
Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com>
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM; pulled and tested the docs page, particularly Badge with onClick events
Summary
Fixes : #2831
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes