feat : enable support for "hostNetwork" in Prometheus CRD by rajpratik71 · Pull Request #5010 · prometheus-operator/prometheus-operator

rajpratik71 · 2022-09-11T21:40:38Z

Description

Enabled support for "hostNetwork" in Prometheus Operator for Prometheus

Needed in many scenarios like:

To bypass the CNI network
In general to reduce the metrics traffic overhead on CNI network in clusters with large no of Nodes.

Signed-off-by: Pratik Raj rajpratik71@gmail.com

Type of change

What type of changes does your code introduce to the Prometheus operator? Put an x in the box that apply.

CHANGE (fix or feature that would cause existing functionality to not work as expected)
FEATURE (non-breaking change which adds functionality)
BUGFIX (non-breaking change which fixes an issue)
ENHANCEMENT (non-breaking change which improves existing functionality)
NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Changelog entry

Please put a one-line changelog entry below. This will be copied to the changelog file during the release process.

feat : enable support for "hostNetwork" in Prometheus CRD

Fixes #2630

rajpratik71 · 2022-09-12T04:26:01Z

Failing build of "checks / Check Documentation formatting and links (pull_request)" is unrelated, i checked it is failing while opening a link which is taking long time while opening.

slashpai · 2022-09-12T04:38:06Z

There is already discussion around hostNetwork support in #2630 and I see that is added in agenda for next office hours meeting

simonpasquier

I've never used hostNetwork: true but I think that the operator needs to modify the container's ports defintion.

From the ContainerPort documentation:

hostPort | Number of port to expose on the host. If specified, this must be a valid port number, 0 < x < 65536. If HostNetwork is specified, this must match ContainerPort. Most containers do not need this.

pkg/apis/monitoring/v1/types.go

rajpratik71 · 2022-09-16T17:37:39Z

I've never used hostNetwork: true but I think that the operator needs to modify the container's ports defintion.

From the ContainerPort documentation:

hostPort | Number of port to expose on the host. If specified, this must be a valid port number, 0 < x < 65536. If HostNetwork is specified, this must match ContainerPort. Most containers do not need this.

HI @simonpasquier ,

Please see the example at https://gist.github.com/Rajpratik71/632321a6fb8c6acc17593e2c887c45a9

When we specify "hostNetwork" for the Pod, there is no need to specify the "hostPort" seperately as when using "hostNetwork" , whole network namespace of Host will be shared, which will also expose the port.

See, below

Although, "hostNetwork" requires "dnsPolicy" to be set as "ClusterFirstWithHostNet".

So, raised a PR #5027 to "enable support for "dnsPolicy" in Prometheus CRD".

simonpasquier · 2022-09-28T07:29:15Z

Although, "hostNetwork" requires "dnsPolicy" to be set as "ClusterFirstWithHostNet".
So, raised a PR #5027 to "enable support for "dnsPolicy" in Prometheus CRD".

After reviewing more carefully, I realize that we may not need to expose dnsPolicy in the CRD. If I understand correctly, hostNetwork: true and dnsPolicy: ClusterFirstWithHostNet go hand in hand so the Prometheus operator could set dnsPolicy to the correct value automatically.
In other words, is there any reason why you'd want to set dnsPolicy to another value than ClusterFirstWithHostNet with host networking?

rajpratik71 · 2022-09-28T09:07:24Z

Although, "hostNetwork" requires "dnsPolicy" to be set as "ClusterFirstWithHostNet".
So, raised a PR #5027 to "enable support for "dnsPolicy" in Prometheus CRD".

After reviewing more carefully, I realize that we may not need to expose dnsPolicy in the CRD. If I understand correctly, hostNetwork: true and dnsPolicy: ClusterFirstWithHostNet go hand in hand so the Prometheus operator could set dnsPolicy to the correct value automatically. In other words, is there any reason why you'd want to set dnsPolicy to another value than ClusterFirstWithHostNet with host networking?

Hi @simonpasquier , I created #5027 for the same purpose to configure the dnsPolicy . When it will get merged , i will rebase this branch to automate the process of setting "dnsPolicy" to "ClusterFirstWithHostNet" in case of "hostNetwork".

simonpasquier · 2022-09-28T13:40:28Z

Sorry if I wasn't clear but my question is: do we need #5027 at all? What if the operator is the only one responsible for setting dnsPolicy?
In practice:

spec.hostNetwork: false (or not set) in the Prometheus CR, the operator doesn't set anything for spec.template.spec.dnsPolicy on the statefulset.
spec.hostNetwork: true, the operator always sets spec.template.spec.dnsPolicy: ClusterFirstWithHostNet on the statefulset.

pkg/prometheus/statefulset.go

pkg/apis/monitoring/v1/types.go

simonpasquier

can you add a unit test with "hostNetwork: true"?

Enabled support for "hostNetwork" in Prometheus Operator Needed in many scenarios like: 1. To bypass the CNI network 2. In general to reduce the metrics traffic overhead on CNI network in clusters with large no of Nodes. Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

rajpratik71 · 2022-10-05T04:41:44Z

can you add a unit test with "hostNetwork: true"?

Hi @simonpasquier , added the test for "hostNetwork: true".

Also, tested the "dnsPolicy" . it is working fine as expected.

simonpasquier

thanks!

…s" CR Object fixes prometheus-community#2689 Released in [v0.60.0](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.60.0) Added at [feat : enable support for "hostNetwork" in Prometheus CRD](prometheus-operator/prometheus-operator#5010) Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

…s" CR Object (#2693) fixes #2689 Released in [v0.60.0](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.60.0) Added at [feat : enable support for "hostNetwork" in Prometheus CRD](prometheus-operator/prometheus-operator#5010) Signed-off-by: Pratik Raj <rajpratik71@gmail.com> Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

…s" CR Object (prometheus-community#2693) fixes prometheus-community#2689 Released in [v0.60.0](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.60.0) Added at [feat : enable support for "hostNetwork" in Prometheus CRD](prometheus-operator/prometheus-operator#5010) Signed-off-by: Pratik Raj <rajpratik71@gmail.com> Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

…s" CR Object (#2693) fixes #2689 Released in [v0.60.0](https://github.com/prometheus-operator/prometheus-operator/releases/tag/v0.60.0) Added at [feat : enable support for "hostNetwork" in Prometheus CRD](prometheus-operator/prometheus-operator#5010) Signed-off-by: Pratik Raj <rajpratik71@gmail.com> Signed-off-by: Pratik Raj <rajpratik71@gmail.com>

rajpratik71 requested a review from a team as a code owner September 11, 2022 21:40

rajpratik71 mentioned this pull request Sep 14, 2022

Support hostNetwork api in prometheus and alertmanager crds #2630

Closed

This was referenced Sep 14, 2022

How can the CRDs offer more flexibility/control for the pod template spec? #4691

Open

Support hostNetwork api in prometheus and alertmanager crds #2631

Closed

simonpasquier reviewed Sep 14, 2022

View reviewed changes

pkg/apis/monitoring/v1/types.go Outdated Show resolved Hide resolved

rajpratik71 force-pushed the prometheus-hostNetwork-support branch 2 times, most recently from 26a5ac6 to 6cf8204 Compare September 16, 2022 15:46

simonpasquier mentioned this pull request Sep 28, 2022

feat: enable support for "dnsPolicy" in Prometheus, AlertManager and Thanos CRD #5027

Closed

5 tasks

rajpratik71 force-pushed the prometheus-hostNetwork-support branch 2 times, most recently from d673245 to acb34d6 Compare October 4, 2022 07:27

simonpasquier reviewed Oct 4, 2022

View reviewed changes

pkg/prometheus/statefulset.go Outdated Show resolved Hide resolved

simonpasquier reviewed Oct 4, 2022

View reviewed changes

pkg/apis/monitoring/v1/types.go Outdated Show resolved Hide resolved

simonpasquier reviewed Oct 4, 2022

View reviewed changes

rajpratik71 force-pushed the prometheus-hostNetwork-support branch from acb34d6 to f88810b Compare October 4, 2022 16:36

rajpratik71 force-pushed the prometheus-hostNetwork-support branch from f88810b to 0b343dd Compare October 4, 2022 16:38

simonpasquier reviewed Oct 5, 2022

View reviewed changes

simonpasquier merged commit 036e7c4 into prometheus-operator:main Oct 5, 2022

rajpratik71 deleted the prometheus-hostNetwork-support branch October 6, 2022 03:09

rajpratik71 mentioned this pull request Nov 16, 2022

[kube-prometheus-stack] : enable "hostNetwork" support for "Prometheus" CR Object prometheus-community/helm-charts#2693

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat : enable support for "hostNetwork" in Prometheus CRD#5010

feat : enable support for "hostNetwork" in Prometheus CRD#5010
simonpasquier merged 1 commit intoprometheus-operator:mainfrom
monitoring-projects:prometheus-hostNetwork-support

rajpratik71 commented Sep 11, 2022 •

edited

Loading

Uh oh!

rajpratik71 commented Sep 12, 2022

Uh oh!

slashpai commented Sep 12, 2022

Uh oh!

simonpasquier left a comment

Uh oh!

Uh oh!

rajpratik71 commented Sep 16, 2022

Uh oh!

simonpasquier commented Sep 28, 2022

Uh oh!

rajpratik71 commented Sep 28, 2022

Uh oh!

simonpasquier commented Sep 28, 2022

Uh oh!

Uh oh!

Uh oh!

simonpasquier left a comment

Uh oh!

rajpratik71 commented Oct 5, 2022

Uh oh!

simonpasquier left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rajpratik71 commented Sep 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Changelog entry

Uh oh!

rajpratik71 commented Sep 12, 2022

Uh oh!

slashpai commented Sep 12, 2022

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rajpratik71 commented Sep 16, 2022

Uh oh!

simonpasquier commented Sep 28, 2022

Uh oh!

rajpratik71 commented Sep 28, 2022

Uh oh!

simonpasquier commented Sep 28, 2022

Uh oh!

Uh oh!

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

rajpratik71 commented Oct 5, 2022

Uh oh!

simonpasquier left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rajpratik71 commented Sep 11, 2022 •

edited

Loading