feat: enable support for "dnsPolicy" in Prometheus, AlertManager and Thanos CRD#5027
Closed
rajpratik71 wants to merge 3 commits intoprometheus-operator:mainfrom
Closed
Conversation
Needed in scenarios like: 1. When using "hostNetwork" 2. for a Pod to ignore DNS settings from the Kubernetes environment Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
5 tasks
Contributor
|
could you take over from #3899? dnsPolicy should be implemented for all CRDs (Prometheus, Alertmanager and ThanosRuler) and having dnsConfig oo would be nice. |
Needed in scenarios like: 1. When using "hostNetwork" 2. for a Pod to ignore DNS settings from the Kubernetes environment Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
Needed in scenarios like: 1. When using "hostNetwork" 2. for a Pod to ignore DNS settings from the Kubernetes environment Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
Contributor
Author
|
Hi @simonpasquier , added support for "dnsPolicy" in Prometheus, AlertManager and Thanos CRD. @prometheus-operator-reviewers Please review |
Contributor
|
See #5010 (comment) but I'm not sure that we need a way to configure dnsPolicy in the CRD after all. |
Contributor
|
I think we can close it for now. If you're willing to ressurect #3899, feel free to do so :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Needed in scenarios like:
Signed-off-by: Pratik Raj rajpratik71@gmail.com
Type of change
What type of changes does your code introduce to the Prometheus operator? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry