Skip to content

Switch logging to Prometheus promlog#88

Merged
SuperQ merged 2 commits intomasterfrom
superq/promlog
May 14, 2020
Merged

Switch logging to Prometheus promlog#88
SuperQ merged 2 commits intomasterfrom
superq/promlog

Conversation

@SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 13, 2020

Update logging library to new standard Prometheus common/promlog.

Signed-off-by: Ben Kochie superq@gmail.com

@SuperQ
Copy link
Contributor Author

SuperQ commented May 13, 2020

cc @cpick, want to review this?

Copy link

@brian-brazil brian-brazil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SuperQ added 2 commits May 14, 2020 17:31
Update logging library to new standard Prometheus common/promlog.

Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ merged commit 6f9d98b into master May 14, 2020
@SuperQ SuperQ deleted the superq/promlog branch May 14, 2020 15:52
SuperQ added a commit that referenced this pull request May 14, 2020
* [CHANGE] Treat failure to collect metric as fatal #83
* [CHANGE] Switch logging to promlog #88
* [FEATURE] Add metrics prefix collect URL param #87

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants