Skip to content

Add metrics prefix collect URL param#87

Merged
SuperQ merged 1 commit intomasterfrom
superq/collect_param
May 12, 2020
Merged

Add metrics prefix collect URL param#87
SuperQ merged 1 commit intomasterfrom
superq/collect_param

Conversation

@SuperQ
Copy link
Contributor

@SuperQ SuperQ commented May 12, 2020

Add URL param collect[] to allow requesting a filterd list of metrics.

Fixes: #61

Signed-off-by: Ben Kochie superq@gmail.com

Add URL param `collect[]` to allow requesting a filterd list of metrics.

Fixes: #61

Signed-off-by: Ben Kochie <superq@gmail.com>
Copy link

@igorwwwwwwwwwwwwwwwwwwww igorwwwwwwwwwwwwwwwwwwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SuperQ SuperQ merged commit dc04cd8 into master May 12, 2020
@SuperQ SuperQ deleted the superq/collect_param branch May 12, 2020 15:05
SuperQ added a commit that referenced this pull request May 14, 2020
* [CHANGE] Treat failure to collect metric as fatal #83
* [CHANGE] Switch logging to promlog #88
* [FEATURE] Add metrics prefix collect URL param #87

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Add collect[] param to additionally filter at scrape time

2 participants