Skip to content

add support for multiple google project IDs#105

Merged
SuperQ merged 1 commit intoprometheus-community:masterfrom
rossmmurray:multi-projects
Jul 27, 2020
Merged

add support for multiple google project IDs#105
SuperQ merged 1 commit intoprometheus-community:masterfrom
rossmmurray:multi-projects

Conversation

@rossmmurray
Copy link
Contributor

Fixes issue #55

Is a more up-to-date version of pull request #60

Signed-off-by: Ross Murray rossmichaelm@gmail.com

Signed-off-by: Ross Murray <ross.murray@farfetch.com>
@rossmmurray
Copy link
Contributor Author

Hi @SuperQ, would you be able to take a look?

Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 42badeb into prometheus-community:master Jul 27, 2020
@rossmmurray rossmmurray deleted the multi-projects branch July 27, 2020 12:39
SuperQ added a commit that referenced this pull request Sep 2, 2020
* Bump Go to 1.15.

* [CHANGE] Do not treat failure to collect metrics as fatal #102
* [FEATURE] Add support for multiple google project IDs #105

Signed-off-by: Ben Kochie <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Sep 2, 2020
SuperQ added a commit that referenced this pull request Sep 2, 2020
* Release 0.11.0

* Bump Go to 1.15.

* [CHANGE] Do not treat failure to collect metrics as fatal #102
* [FEATURE] Add support for multiple google project IDs #105

Signed-off-by: Ben Kochie <superq@gmail.com>

* Update vendoring

Signed-off-by: Ben Kochie <superq@gmail.com>

* Bump promu version.

Signed-off-by: Ben Kochie <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants