Monitor metrics from multiple projects#60
Closed
ashiddo11 wants to merge 1 commit intoprometheus-community:masterfrom
Closed
Monitor metrics from multiple projects#60ashiddo11 wants to merge 1 commit intoprometheus-community:masterfrom
ashiddo11 wants to merge 1 commit intoprometheus-community:masterfrom
Conversation
SuperQ
reviewed
Apr 10, 2020
Contributor
SuperQ
left a comment
There was a problem hiding this comment.
Minor nit, otherwise LGTM.
| var ( | ||
| projectID = kingpin.Flag( | ||
| "google.project-id", "Google Project ID ($STACKDRIVER_EXPORTER_GOOGLE_PROJECT_ID).", | ||
| "google.project-id", "Comma seperated Google Project IDs ($STACKDRIVER_EXPORTER_GOOGLE_PROJECT_ID).", |
Contributor
There was a problem hiding this comment.
Minor nit:
Suggested change
| "google.project-id", "Comma seperated Google Project IDs ($STACKDRIVER_EXPORTER_GOOGLE_PROJECT_ID).", | |
| "google.project-id", "Comma separated list of Google Project IDs ($STACKDRIVER_EXPORTER_GOOGLE_PROJECT_ID).", |
Contributor
|
This needs to be re-based on master. |
Contributor
|
Closing in favor of #105 |
|
Hello, it is ok to take multiple project but it still the problem to pass multiple credential? any idea please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #55