fix: ignore setting google_dataplex.max_messages#1261
Merged
Conversation
010cdc6 to
2aabc2c
Compare
sysadmind
approved these changes
Feb 18, 2026
| // NOTE: If you add more vartypes here, you must update the supported | ||
| // types in normaliseUnit() below | ||
| query := "SELECT name, setting, COALESCE(unit, ''), short_desc, vartype FROM pg_settings WHERE vartype IN ('bool', 'integer', 'real') AND name != 'sync_commit_cancel_wait';" | ||
| query := "SELECT name, setting, COALESCE(unit, ''), short_desc, vartype FROM pg_settings WHERE vartype IN ('bool', 'integer', 'real') AND name NOT IN ('sync_commit_cancel_wait', 'google_dataplex.max_messages');" |
Contributor
There was a problem hiding this comment.
Maybe we should have a comment about why we ignore it? Future user won't have the context.
Contributor
Author
There was a problem hiding this comment.
Added a comment!
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc>
2aabc2c to
2c2a8a6
Compare
Signed-off-by: Cristian Greco <cristian@regolo.cc>
2c2a8a6 to
f5ff6ac
Compare
sysadmind
approved these changes
Feb 18, 2026
JiriCtvrtka
pushed a commit
to percona/postgres_exporter
that referenced
this pull request
Feb 26, 2026
…ity#1261) * fix: ignore setting `google_dataplex.max_messages` Followup of prometheus-community#1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #1252
Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources.