fix: Do not crash on bad pg_settings value#1252
Merged
SuperQ merged 3 commits intoprometheus-community:masterfrom Feb 2, 2026
Merged
fix: Do not crash on bad pg_settings value#1252SuperQ merged 3 commits intoprometheus-community:masterfrom
SuperQ merged 3 commits intoprometheus-community:masterfrom
Conversation
pg_settings metrics would panic when the parsing fails. This is a poor experience for users. An exporter should not panic. This skips unparsable metrics and instead logs a warning. fixes prometheus-community#1240 Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
cristiangreco
approved these changes
Feb 2, 2026
Contributor
cristiangreco
left a comment
There was a problem hiding this comment.
Left just a nitpick comment.
|
@SuperQ can you please review? |
SuperQ
requested changes
Feb 2, 2026
Contributor
SuperQ
left a comment
There was a problem hiding this comment.
Looks good, minor cleanup needed.
Remove panic comment for unsupported vartype. Signed-off-by: Joe Adams <github@joeadams.io>
SuperQ
approved these changes
Feb 2, 2026
|
When is the next release due with this fix included? |
|
Thank you all for this+++ |
Contributor
Planning to cut a release this week |
|
Not really a fan of having this be logged every 30 seconds. That's 43200 logs per deployment per day |
4 tasks
cristiangreco
added a commit
that referenced
this pull request
Feb 16, 2026
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources.
cristiangreco
added a commit
that referenced
this pull request
Feb 16, 2026
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc>
Contributor
Agree with the log being annoying in this case, unfortunately. Followed up with #1261 |
cristiangreco
added a commit
that referenced
this pull request
Feb 18, 2026
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc>
sysadmind
pushed a commit
that referenced
this pull request
Feb 18, 2026
* fix: ignore setting `google_dataplex.max_messages` Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
JiriCtvrtka
pushed a commit
to percona/postgres_exporter
that referenced
this pull request
Feb 26, 2026
…ity#1261) * fix: ignore setting `google_dataplex.max_messages` Followup of prometheus-community#1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
dev-blueMagician
added a commit
to dev-blueMagician/postgres_exporter
that referenced
this pull request
Mar 3, 2026
* fix: ignore setting `google_dataplex.max_messages` Followup of prometheus-community/postgres_exporter#1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
|
Not really a fan of having this be logged every 30 seconds. That's 43200 logs per deployment per day |
4 tasks
cristiangreco
added a commit
that referenced
this pull request
Feb 16, 2026
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources.
cristiangreco
added a commit
that referenced
this pull request
Feb 16, 2026
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc>
Contributor
Agree with the log being annoying in this case, unfortunately. Followed up with #1261 |
cristiangreco
added a commit
that referenced
this pull request
Feb 18, 2026
Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc>
sysadmind
pushed a commit
that referenced
this pull request
Feb 18, 2026
* fix: ignore setting `google_dataplex.max_messages` Followup of #1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
JiriCtvrtka
pushed a commit
to percona/postgres_exporter
that referenced
this pull request
Feb 26, 2026
…ity#1261) * fix: ignore setting `google_dataplex.max_messages` Followup of prometheus-community#1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
dev-blueMagician
added a commit
to dev-blueMagician/postgres_exporter
that referenced
this pull request
Mar 3, 2026
* fix: ignore setting `google_dataplex.max_messages` Followup of prometheus-community/postgres_exporter#1252 Ignore this setting altogether, as logging a warn at each scrape for a cloud provider specific entry seems a waste of resources. Signed-off-by: Cristian Greco <cristian@regolo.cc> * add comment Signed-off-by: Cristian Greco <cristian@regolo.cc> --------- Signed-off-by: Cristian Greco <cristian@regolo.cc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pg_settings metrics would panic when the parsing fails. This is a poor experience for users. An exporter should not panic. This skips unparsable metrics and instead logs a warning.
fixes #1240
These tests are weird, but I think that's a future PR as we refactor.