test(remote)[PART4c]: Refactor remote handler tests to use teststorage.Appendable mock#17838
Closed
test(remote)[PART4c]: Refactor remote handler tests to use teststorage.Appendable mock#17838
Conversation
Signed-off-by: bwplotka <bwplotka@gmail.com>
18e0334 to
3179d07
Compare
This was referenced Jan 12, 2026
3179d07 to
cbf00bb
Compare
Found in #17838 and by Krajo comment Signed-off-by: bwplotka <bwplotka@gmail.com>
…impl Signed-off-by: bwplotka <bwplotka@gmail.com>
49ea7b0 to
1a80486
Compare
…e.Appendable mock Signed-off-by: bwplotka <bwplotka@gmail.com>
cbf00bb to
32881bc
Compare
aknuds1
reviewed
Jan 14, 2026
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
I did a quick scan, and didn't find any problems that aren't in the previous PRs this is based on. I'll wait until the PRs depended on are merged, before making any final review.
bwplotka
added a commit
that referenced
this pull request
Jan 14, 2026
…le (#17834) * feat(teststorage)[PART4a]: Add AppendableV2 support for mock Appendable Signed-off-by: bwplotka <bwplotka@gmail.com> * fix: adjusted AppenderV1 flow for reliability Found in #17838 and by Krajo comment Signed-off-by: bwplotka <bwplotka@gmail.com> * addressed comments Signed-off-by: bwplotka <bwplotka@gmail.com> * fix broken appV2 commit and rollback; added tests Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>
1a80486 to
8a2921e
Compare
ywwg
reviewed
Jan 14, 2026
| // Append implements storage.AppenderV2. | ||
| func (t *timestampTrackerV2) Append(ref storage.SeriesRef, _ labels.Labels, _, ts int64, _ float64, h *histogram.Histogram, fh *histogram.FloatHistogram, opts storage.AOptions) (storage.SeriesRef, error) { | ||
| switch { | ||
| case fh != nil, h != nil: |
Member
There was a problem hiding this comment.
is it considered a violation of spec to send both a histogram and float histogram in a single call? (if not, then shouldn't we count 2 if both are set?)
051cdd6 to
f61a83b
Compare
Member
Author
|
Switched to per ingestion PR, e.g. OTLP #17992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting work from #17675 into smaller PRs.
This PR:
Related to #17632
Chained on top of:
Does this PR introduce a user-facing change?