tests: move OTLP handler tests to teststorage.Appendable; increase test coverage.#17992
Merged
tests: move OTLP handler tests to teststorage.Appendable; increase test coverage.#17992
Conversation
aknuds1
requested changes
Feb 2, 2026
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
Please see comment about every test case modifying a shared slice.
aknuds1
reviewed
Feb 2, 2026
aknuds1
reviewed
Feb 2, 2026
Contributor
aknuds1
left a comment
There was a problem hiding this comment.
Just fixing a typo, to clarify a TODO.
6ebddd9 to
976c79e
Compare
Signed-off-by: bwplotka <bwplotka@gmail.com>
976c79e to
f6cd5fb
Compare
Member
Author
|
Done, thanks! |
22 tasks
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Will Bollock <wbollock@linode.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
Signed-off-by: bwplotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progresses #17632
Depends on bwplotka/a2-otlp-1
Switching tests to a new mock framework so switch to AppenderV2 PR will be clean.
On the way I increased test coverage:
And removed unnecessary cases e.g.:
Does this PR introduce a user-facing change?