[FEATURE] AWS SD: Add MSK Role#17600
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Feb 5, 2026
Merged
Conversation
9d399e9 to
d88b2a1
Compare
Member
|
Hello from the bug scrub! We haven't identified a reviewer at this time. Who would be a good candidate? Also pinging @sysadmind @alanprot possibly? |
Collaborator
Author
|
@SuperQ Might be a good reviewer as he has reviewed some of the other AWS Service Discovery. |
SuperQ
reviewed
Nov 25, 2025
d88b2a1 to
f48cb27
Compare
a57ffbb to
200045a
Compare
1a82c0f to
dbfefd7
Compare
Collaborator
Author
|
We should rebase on top of #17769 and then add a dedicated MSK test to |
bb56360 to
18a5794
Compare
18a5794 to
636c2b0
Compare
636c2b0 to
b46a8bf
Compare
Collaborator
Author
|
@SuperQ would you be able to take another look when you get a chance? |
…timestamp) (prometheus#17411) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com>
b46a8bf to
a65d075
Compare
Collaborator
Author
|
@sysadmind would you be able to look when you get a chance? |
Collaborator
Author
|
Hi, I have an immediate need for this so am happy to maintain it. |
Collaborator
Author
|
@SuperQ Sorry to nudge you, are you able to take a look? I have another PR that this is holding up. Thanks |
SuperQ
approved these changes
Feb 5, 2026
Member
SuperQ
left a comment
There was a problem hiding this comment.
LGTM, sorry, this review got lost in my inbox.
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…timestamp) (prometheus#17411) (prometheus#17600) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Will Bollock <wbollock@linode.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…timestamp) (prometheus#17411) (prometheus#17600) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…timestamp) (prometheus#17411) (prometheus#17600) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…timestamp) (prometheus#17411) (prometheus#17600) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…timestamp) (prometheus#17411) (prometheus#17600) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
wbollock
pushed a commit
to wbollock/prometheus
that referenced
this pull request
Feb 6, 2026
…timestamp) (prometheus#17411) (prometheus#17600) Relates to prometheus#16944 (comment) Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: matt-gp <small_minority@hotmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS offers a Kafka service called Managed Streaming Kafka (MSK). This allows users to run Kafka clusters without having the overhead of managing the infrastructure themselves.
As part of the monitoring configuration for these clusters, you can enable the JMX Exporter and/or Node Exporter, so that the nodes will expose metrics that users can collect.
There are some caveats with this:
Which issue(s) does the PR fix:
Does this PR introduce a user-facing change?