Fix(discovery/aws): Create Copies of Default Config#17769
Merged
SuperQ merged 1 commit intoprometheus:mainfrom Jan 22, 2026
Merged
Fix(discovery/aws): Create Copies of Default Config#17769SuperQ merged 1 commit intoprometheus:mainfrom
SuperQ merged 1 commit intoprometheus:mainfrom
Conversation
665b8a6 to
cadeaaa
Compare
Collaborator
Author
|
@SuperQ you might be a good person to review |
Member
|
Thanks! We would need a test for this. |
cadeaaa to
8c37241
Compare
Collaborator
Author
|
Updated to include a test |
8c37241 to
4418c96
Compare
Signed-off-by: matt-gp <small_minority@hotmail.com>
4418c96 to
72a6475
Compare
Collaborator
Author
|
@roidelapluie anyway we can push this forward??? Thanks |
SuperQ
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
When multiple jobs use
aws_sd_configswith different configurations (like different ports/filters/clusters), they were all sharing the same underlying configuration object. This happened because the code was assigning pointers to global default configuration variables instead of making copies. This meant that when configuration was changed for one job, it was also change it for others.Does this PR introduce a user-facing change?