chore: add a "make bump-go-version" to handle Go bumps across all files#17090
Merged
machine424 merged 2 commits intoprometheus:mainfrom Sep 1, 2025
Merged
chore: add a "make bump-go-version" to handle Go bumps across all files#17090machine424 merged 2 commits intoprometheus:mainfrom
machine424 merged 2 commits intoprometheus:mainfrom
Conversation
This was referenced Aug 26, 2025
Co-authored-by: machine424 <ayoubmrini424@gmail.com> Signed-off-by: machine424 <ayoubmrini424@gmail.com>
4 tasks
Member
Author
|
cc @SuperQ |
Duciwuci
reviewed
Aug 28, 2025
Contributor
Duciwuci
left a comment
There was a problem hiding this comment.
Unfortunately you get for the Job Test with previous Go Version:
- image: quay.io/prometheus/golang-builder:1.23-base
+ image: quay.io/prometheus/golang-builder:1.25-base
For this Job, it is important to stay at N-1 Version instead of bumping this Job to the latest version.
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
Member
Author
|
nice catch, I think the order is messed up, pushed a new version |
Duciwuci
approved these changes
Aug 28, 2025
Contributor
|
Thanks. LGTM for me. I'm not a Maintainer though, so let's wait for further Feedback. Thanks for taking this! |
SuperQ
reviewed
Aug 28, 2025
SuperQ
approved these changes
Aug 31, 2025
Contributor
|
@machine424 ready to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Fixes #16446
Supersedes #16488
Does this PR introduce a user-facing change?
This should help with partial updates like in #17080, we currently need to bump the version in too many places, the script can help keep track of that.
run using
make bump-go-version