Script for golang version update | Issue 16446 by manojks1999 · Pull Request #16488 · prometheus/prometheus

manojks1999 · 2025-04-25T20:13:21Z

aknuds1 · 2025-04-27T12:34:39Z

You need to sign your commit, as otherwise the DCO check fails.

machine424

thanks for this.
Have some suggestions to simplify this.

machine424 · 2025-04-29T19:35:57Z

scripts/update_go_version.sh

+sed -i.bak -E "s/^go [0-9]+\.[0-9]+\.[0-9]+$/go ${CURRENT_VERSION}.0/" documentation/examples/remote_storage/go.mod
+
+# Clean up backup files
+find . -name "*.bak" -type f -delete


no need for backups, git should take care of that

machine424 · 2025-04-29T19:44:36Z

scripts/update_go_version.sh

+#
+# Update Go version across the Prometheus project.
+# Run from repository root.
+set -e


nit: just set -euo pipefail as the others.

machine424 · 2025-04-29T19:45:01Z

scripts/update_go_version.sh

+set -e
+set -u
+
+if ! [[ "$0" =~ "scripts/update_go_version.sh" ]]; then


no need for this, the makefile target should/will be used.

machine424 · 2025-04-29T19:50:13Z

scripts/update_go_version.sh

+echo "Updating Go version from ${CURRENT_VERSION} to ${NEW_VERSION}"
+
+# Update .promu.yml
+sed -i.bak -E "s/^([[:space:]]*version:[[:space:]]*)[0-9]+\.[0-9]+/\1${NEW_VERSION}/" .promu.yml


we can forget about the spaces.
Also use CURRENT_VERSION instead of a regex

machine424 · 2025-04-29T19:52:20Z

scripts/update_go_version.sh

+sed -i.bak -E "s/^([[:space:]]*version:[[:space:]]*)[0-9]+\.[0-9]+/\1${NEW_VERSION}/" .promu.yml
+
+# Update go.mod
+sed -i.bak -E "s/^go [0-9]+\.[0-9]+\.[0-9]+$/go ${CURRENT_VERSION}.0/" go.mod


let's use go mod edit -go= for those.

machine424 · 2025-04-29T20:04:19Z

Makefile

+
+.PHONY: update-go-version
+update-go-version:
+	@echo ">> updating Go version"


Suggested change

@echo ">> updating Go version"

@echo ">> updating Go minor version"

machine424 · 2025-04-29T20:07:01Z

Makefile

+.PHONY: update-go-version
+update-go-version:
+	@echo ">> updating Go version"
+	@read -p "Current Go version (e.g., 1.22): " current_version && \


actually, we can even get the N-1 version from go.mod using something like go mod edit -json go.mod | jq -r .Go | cut -d '.' -f1,2 (assuming jq is available, no need to check for that)

so we can make the script take no argument, and have something like:
we can state that the script only handles minor bumps

# with the help of an llm version=$(go mod edit -json go.mod | jq -r .Go) # Extract major & minor major=${version%%.*} # "1" minor=${version#*.}; minor=${minor%%.*} # "23" # Bump new_minor=$(( minor + 1 )) # e.g. 24 # Rejoin echo "${major}.${minor}"

this will pick up version from go.mod file which we need to update to new version is we manually change the version to new version in go.mod file ?

not sure I get the issue, could you provide an example?

machine424 · 2025-04-29T20:07:31Z

scripts/update_go_version.sh

+    gsub(/image: quay.io\/prometheus\/golang-builder:[0-9]+\.[0-9]+(-base)/, "image: quay.io/prometheus/golang-builder:'"${CURRENT_VERSION}"'-base");
+  }
+}
+{print}' .github/workflows/ci.yml > .github/workflows/ci.yml.new && mv .github/workflows/ci.yml.new .github/workflows/ci.yml


just change the files in-place

machine424 · 2025-04-29T20:07:38Z

scripts/update_go_version.sh

+# Clean up backup files
+find . -name "*.bak" -type f -delete
+
+echo "Go version updated successfully from ${CURRENT_VERSION} to ${NEW_VERSION}"


no need for this one

machine424 · 2025-04-29T20:07:56Z

scripts/update_go_version.sh

+
+
+# Update golangci-lint.yml - replace any version with the new version
+sed -i.bak "s/go-version: [0-9][0-9]*\.[0-9][0-9]*\.x/go-version: ${NEW_VERSION}.x/g" scripts/golangci-lint.yml


use exact match, no need for regex

machine424

some last suggestions.

machine424 · 2025-05-27T04:06:11Z

scripts/update_go_version.sh

+# Update remote_storage example go.mod
+(cd documentation/examples/remote_storage && go mod edit -go=${CURRENT_VERSION}.0)
+
+echo "Please review the changes and commit them."


let's have an blank line at the end

machine424 · 2025-05-27T04:12:53Z

scripts/update_go_version.sh

+
+echo "Current version: ${CURRENT_VERSION}"
+echo "New version: ${NEW_VERSION}"
+echo "Updating Go version from ${CURRENT_VERSION} to ${NEW_VERSION}"


Let's remove this as redundant.

machine424 · 2025-05-27T04:18:02Z

scripts/update_go_version.sh

+# Get current Go version from go.mod and calculate next minor version
+current_full_version=$(go mod edit -json go.mod | jq -r .Go)
+# Extract major & minor
+major=${current_full_version%%.*}                                # "1"
+minor=${current_full_version#*.}; minor=${minor%%.*}            # "23"


not: we can also, in one line do
IFS='.' read -r major minor _ <<< "$(go mod edit -json go.mod | jq -r .Go)"

machine424 · 2025-05-27T05:43:07Z

scripts/update_go_version.sh

+# Update GitHub workflow files
+sed -i '' -E "s|(quay\.io/prometheus/golang-builder:)[0-9]+\.[0-9]+(-base)|\1${NEW_VERSION}\2|g" .github/workflows/ci.yml
+sed -i '' -E "s/go-version: [0-9]+\.[0-9]+\.x/go-version: ${NEW_VERSION}.x/" .github/workflows/ci.yml
+sed -i '' -E "/name: Go tests with previous Go version/,/steps:/ { s|(quay\.io/prometheus/golang-builder:)[0-9]+\.[0-9]+(-base)|\1${CURRENT_VERSION}\2|g; }" .github/workflows/ci.yml


no need to match on the whole quay\.io/prometheus/..., just golang-builder:...

machine424 · 2025-05-27T05:43:20Z

scripts/update_go_version.sh

+go mod edit -go=${CURRENT_VERSION}.0
+
+# Update GitHub workflow files
+sed -i '' -E "s|(quay\.io/prometheus/golang-builder:)[0-9]+\.[0-9]+(-base)|\1${NEW_VERSION}\2|g" .github/workflows/ci.yml


we can do without the [0-9]+... given that we know the maj.min or the previous, current and new versions...

machine424 · 2025-05-27T05:45:59Z

Thanks, don't hesitate to resolve conversations when done.

manojks1999 · 2025-05-31T07:02:34Z

Thanks, don't hesitate to resolve conversations when done.

Okay sure, will be working these changes

beorn7 · 2025-07-09T12:27:01Z

@manojks1999 are you still planning to complete this?

machine424 · 2025-08-26T16:18:17Z

thanks for this.
taking over in #17090

Added script for golang version update

04d5ae0

machine424 reviewed Apr 29, 2025

View reviewed changes

Change with picking up verisons

96bd263

aknuds1 requested a review from machine424 May 26, 2025 15:25

machine424 reviewed May 27, 2025

View reviewed changes

machine424 mentioned this pull request Aug 26, 2025

chore: add a "make bump-go-version" to handle Go bumps across all files #17090

Merged

machine424 closed this Aug 26, 2025

	@echo ">> updating Go version"
	@echo ">> updating Go minor version"



		# Update golangci-lint.yml - replace any version with the new version
		sed -i.bak "s/go-version: [0-9][0-9]\.[0-9][0-9]\.x/go-version: ${NEW_VERSION}.x/g" scripts/golangci-lint.yml

Conversation

manojks1999 commented Apr 25, 2025

Uh oh!

aknuds1 commented Apr 27, 2025

Uh oh!

machine424 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machine424 Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machine424 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

machine424 commented May 27, 2025

Uh oh!

manojks1999 commented May 31, 2025

Uh oh!

beorn7 commented Jul 9, 2025

Uh oh!

machine424 commented Aug 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

machine424 Apr 29, 2025 •

edited

Loading