Thanks for this, unfortunately, there are other places where the version needs to be bumped.
let's get #17090 merged first, then you can update your PR with a make bump-go-version

Thanks for this, unfortunately, there are other places when the version needs to be bumped.

let's get #17090 merged first, then you can update your PR with a make bump-go-version

Good to know though, I will adjust my PR then :)

@machine424 I used ur Make-Target here 😄
Updated my PR.

/prombench main

⏱️ Welcome to Prometheus Benchmarking Tool. ⏱️

Compared versions: PR-17080 and main

After the successful deployment (check status here), the benchmarking results can be viewed at:

• Prometheus Meta
• Prombench Dashboard
• Grafana Explorer, Loki logs
• Parca profiles (e.g. in-use memory)

Available Commands:

• To restart benchmark: /prombench restart main
• To stop benchmark: /prombench cancel
• To print help: /prombench help

/prombench restart main

@Duciwuci is not a org member nor a collaborator and cannot execute benchmarks.

@Duciwuci is not a org member nor a collaborator and cannot execute benchmarks.

the root go.mod was already bumped and that's what matters for the benchmark. No need to re-run it.

Also, please adjust

I assume that (some go.mod not being updated) was caught by

Also, we can now get rid of the tools.go in https://github.com/prometheus/prometheus/tree/2cbeef6d9582d7dee2bbe493a7cb42bda8f37553/internal/tools using https://tip.golang.org/doc/go1.24#tools and defining then at the root go.mod. I you want to work on that in a follow up PR. (I can assign #16442 to you)

@Duciwuci is not a org member nor a collaborator and cannot execute benchmarks.

the root go.mod was already bumped and that's what matters for the benchmark. No need to re-run it.

Also, please adjust

prometheus/scripts/bump_go_version.sh

Line 19 in 2cbeef6

# Update go.mod files

to include the two go.mod that you discovered.
I assume that (some go.mod not being updated) was caught by

prometheus/scripts/check-go-mod-version.sh

Line 4 in 2cbeef6

, otherwise we'd need to adjust that script as well.
Also, we can now get rid of the tools.go in https://github.com/prometheus/prometheus/tree/2cbeef6d9582d7dee2bbe493a7cb42bda8f37553/internal/tools using https://tip.golang.org/doc/go1.24#tools and defining then at the root go.mod. I you want to work on that in a follow up PR. (I can assign #16442 to you)

Thanks, I will adjust your script first and the second script will catch it correctly afterwards.

Let's get some process on the update first before I take further tasks :D

/prombench cancel
Nothing noteworthy

Benchmark cancel is in progress.