This needs to wait for Prometheus to update to Go 1.25.

Also we're not going to remove Endpoints right away - see #16684.

Can you explain more of the changes lumped under "adjust", please?

Also we're not going to remove Endpoints right away - see #16684.

Can you explain more of the changes lumped under "adjust", please?

Thanks. Then the golang-ci linter needs to ignore the whole validation in the file.
If we want to keep supporting Endpoints, then we actually needs none of my changes and just need an adjustment in the go.mod.

Then we also don't need to wait for Go 1.25?

The reason to wait for 1.25 is so the “previous version of Go” tests move to 1.24.

The reason to wait for 1.25 is so the “previous version of Go” tests move to 1.24.

Then we wait, thanks!

@bboreham Go 1.25 is released!

Now waiting for #17080

Now waiting for #17080

Hi @Duciwuci , it got merged a couple of days ago. Can this continue now ? There's a little train of dependencies waiting on this one now.
Thanks!

I attempted to address all existing feedback on this PR to push this update forward in #17200

reviewed #17200 without knowing this one exists.

@mjlshen please check with @Duciwuci how you want to move forward.

As Bryan mentioned, we'll not be removing the Endpoints role, https://github.com/prometheus/prometheus/pull/16684/files added a warning about the deprecation in the docs.
another thing we can do is mark all exposed things e.g. NewEndpoints with a // Deprecated: to warn library users.

reviewed #17200 without knowing this one exists.

@\mjlshen please check with @\Duciwuci how you want to move forward.

Understood, I just realized it's been sitting for some time with unaddressed feedback and assumed Duciwuci was busy with life as has happened to myself many times. Just trying to help push it forward together so that we can upgrade corresponding downstream dependencies!

As Bryan mentioned, we'll not be removing the Endpoints role, https://github.com/prometheus/prometheus/pull/16684/files added a warning about the deprecation in the docs.

I've done this in #17200 because this MR has had that feedback for a while

another thing we can do is mark all exposed things e.g. NewEndpoints with a // Deprecated: to warn library users.

I'm happy to do this

Hi, I was on Vacation until today. In favor for #17200 we can close this.

Thanks @mjlshen

Thanks for the initial effort!