Update to k8s.io v0.33.5#17200
Merged
machine424 merged 3 commits intoprometheus:mainfrom Sep 26, 2025
Merged
Conversation
machine424
reviewed
Sep 17, 2025
Member
machine424
left a comment
There was a problem hiding this comment.
thanks, I was looking at taking care of this.
some suggestions
1c85e12 to
f69f2b7
Compare
mjlshen
commented
Sep 18, 2025
machine424
reviewed
Sep 23, 2025
Member
machine424
left a comment
There was a problem hiding this comment.
some suggestions.
Normally, we only include changes that affect Prometheus binary users in the release notes (for the role deprecation, we already mention that in the docs). In this case, the deprecation is mainly relevant for Prometheus library users, who will already be warned via the // Deprecated comment. So, I’d recommend just putting NONE in the release-note block.
Signed-off-by: Michael Shen <mishen@umich.edu>
Signed-off-by: Michael Shen <mishen@umich.edu>
b301320 to
d4c6cc2
Compare
Signed-off-by: Michael Shen <mishen@umich.edu>
d4c6cc2 to
1eaddc6
Compare
Contributor
Author
|
@machine424 Just making sure, is there anything I need to do? |
Member
waited so others can double check it |
1 task
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does the PR fix:
Continues the work of #16534 and #16890 by updating the k8s.io dependencies to v0.33.5, replacing deprecated code where relevant, and adding deprecation notices to the
apiv1.EndpointsAPI as it has been deprecated in K8s starting in v1.33+. We will still support it for some time per #16890 (comment), but this will nudge downstream users to leverage theEndpointSliceAPI instead.Does this PR introduce a user-facing change?