[PERF] Remote-write: re-use memory to read WAL data#16197
Merged
bwplotka merged 1 commit intoprometheus:mainfrom Mar 11, 2025
Merged
[PERF] Remote-write: re-use memory to read WAL data#16197bwplotka merged 1 commit intoprometheus:mainfrom
bwplotka merged 1 commit intoprometheus:mainfrom
Conversation
The `:=` causes new variables to be created, which means the outer slice stays at nil, and new memory is allocated every time round the loop. Extracted from prometheus#16182 Credit to @bwplotka. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Member
Author
|
@mmorel-35 is there a linter that will catch variable shadowing like this? |
Contributor
Contributor
|
@mmorel-35 thanks for sharing the insights, I can try to fix these in smaller commits |
Contributor
|
a little bit more context here: #16198 |
Member
Author
|
To continue the thread here, #16198 is not obviously an improvement. |
bwplotka
approved these changes
Mar 11, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks!
In my PR I also added a clear interface comments on why this should be safe (no one reusing those slices as implementer). That's fine to merge those comments later (as long as eventually). I also double checked the implementers, no one is reusing those slices, so.. let's merge, thanks! 💪🏽
machine424
pushed a commit
to machine424/prometheus
that referenced
this pull request
Mar 26, 2025
The `:=` causes new variables to be created, which means the outer slice stays at nil, and new memory is allocated every time round the loop. Extracted from prometheus#16182 Credit to @bwplotka. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:=causes new variables to be created, which means the outer slice stays at nil, and new memory is allocated every time round the loop.Extracted from #16182
Credit to @bwplotka.