Closed
Conversation
Signed-off-by: miledxz <zedsprogramms@gmail.com>
Member
|
Those ones look deliberate. Also not likely to help performance since they're run once at startup. |
Contributor
Author
|
@bboreham thanks for fast review |
Contributor
|
I don't see why it would be a good idea to ban shadowing of |
Member
|
I'd be ok changing code to eliminate shadowing and hence reduce scope for confusion, but in this particular case I would change the outer |
Member
|
Closing as unwanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:=is causing new variables for errors to be created, this PR is just an example for https://github.com/mmorel-35/prometheus/actions/runs/13772600546/job/38514471955?pr=408 fixes,for example at some places like here:
https://github.com/miledxz/prometheus/blob/main/cmd/prometheus/main.go#L661 we just can't remove
:=as the funcs returns another variable, one of the workarounds is renaming err variable while keeping code clean and simple