Migrating ec2 service discovery to the AWS sdk v2#15735
Closed
alanprot wants to merge 2 commits intoprometheus:mainfrom
Closed
Migrating ec2 service discovery to the AWS sdk v2#15735alanprot wants to merge 2 commits intoprometheus:mainfrom
alanprot wants to merge 2 commits intoprometheus:mainfrom
Conversation
Signed-off-by: alanprot <alanprot@gmail.com>
Member
5 tasks
Member
Closed
Member
|
Thanks for giving this a try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #15572
Creating as draft if someone wanna continue the work as I still did not test E2E.
All tests are passing.
Both, ec2 and Lightsail is using the v2 SDK.