chore(deps): Upgrade AWS SDK to v2#16950
Merged
sysadmind merged 6 commits intoprometheus:mainfrom Aug 8, 2025
Merged
Conversation
AWS SDK v1 is end of life soon, so migrate to the V2 SDK. The credential loading should work more consistently with other projects that use the SDK and load credentials from the appropriate locations including from environment variables. This affects the EC2 and Lightsail service discovery features. Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
bwplotka
approved these changes
Jul 30, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks a lot! Added some comments, but generally looks good.
Some AWS setup would be nice to have.. shouldn't be hard, we could ask user mailing list or Slack, wanna ask there?
Signed-off-by: Joe Adams <github@joeadams.io>
Signed-off-by: Joe Adams <github@joeadams.io>
bwplotka
approved these changes
Aug 1, 2025
Member
bwplotka
left a comment
There was a problem hiding this comment.
Thanks! LGTM, let's ping community on -dev for someone to test this, but otherwise we should time box this (1w?), merge and assume any bugs will be caught by tests or RC process.
Signed-off-by: Joe Adams <github@joeadams.io>
Member
|
some tests are failing after merge to main @sysadmind Otherwise I think we should merge slowly, we waited enough. |
Signed-off-by: Joe Adams <github@joeadams.io>
Contributor
Author
|
That's what I get for trying to resolve merge conflicts in the Github web UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS SDK v1 is end of life soon, so migrate to the V2 SDK. The credential loading should work more consistently with other projects that use the SDK and load credentials from the appropriate locations including from environment variables. This affects the EC2 and Lightsail service discovery features.
Fixes #15572
Supersedes #15735
I do not have access to an AWS environment currently to test this fully so if anyone would be kind enough to try this out and let me know their experience, I would be very grateful.