Email is green if no firing alerts#1475
Merged
stuartnelson3 merged 1 commit intoprometheus:masterfrom Jul 23, 2018
Merged
Conversation
Signed-off-by: Benjamin Chess <bchess@gmail.com>
stuartnelson3
approved these changes
Jul 23, 2018
Contributor
|
Thanks! |
gabreal
pushed a commit
to paritytech/alertmanager
that referenced
this pull request
Jul 31, 2018
Signed-off-by: Benjamin Chess <bchess@gmail.com>
mxinden
pushed a commit
to mxinden/alertmanager
that referenced
this pull request
Aug 14, 2018
Signed-off-by: Benjamin Chess <bchess@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@stuartnelson3
Emails that contain no firing alerts should not be red. This makes them green.
#859 was a past (never merged) attempt to do something similar, but this is simpler