Fix template color head table in email template#859
Closed
agareev wants to merge 2 commits intoprometheus:masterfrom
agareev:master
Closed
Fix template color head table in email template#859agareev wants to merge 2 commits intoprometheus:masterfrom agareev:master
agareev wants to merge 2 commits intoprometheus:masterfrom
agareev:master
Conversation
brian-brazil
reviewed
Jun 9, 2017
template/email.html
Outdated
| {{ if gt (len .Alerts.Firing) 0 }} | ||
| <td class="alert alert-warning"> | ||
| {{ end }} | ||
| {{ if gt (len .Alerts.Resolved) 0 }} |
Contributor
There was a problem hiding this comment.
Both of these can be true, you want an else here.
Author
|
I've fixed conditionals. |
Author
Contributor
|
This logic doesn't make sense. Some alerts being resolved does not mean things are okay, as there are still alerts firing. |
Author
|
I haven't understand what did you mean (sorry for my bad english). |
Member
|
@brian-brazil Could you help @agareev with this PR again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.