This repository was archived by the owner on Oct 20, 2025. It is now read-only.
Fix checking terminating pod for non-calico CNI#1446
Merged
song-jiang merged 1 commit intoJul 12, 2021
Conversation
57d184e to
c3785c6
Compare
song-jiang
added a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 12, 2021
…rmination Fix checking terminating pod for non-calico CNI (cherry picked from commit 719c24d)
song-jiang
added a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 12, 2021
…rmination Fix checking terminating pod for non-calico CNI (cherry picked from commit 719c24d) And Revert back to old API v3
mgleung
added a commit
that referenced
this pull request
Jul 12, 2021
Merge pull request #1446 from song-jiang/song-fix-pod-termination
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 13, 2021
Merge pull request projectcalico#1446 from song-jiang/song-fix-pod-termination (cherry picked from commit 9041b53)
3 tasks
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 13, 2021
Merge pull request projectcalico#1446 from song-jiang/song-fix-pod-termination (cherry picked from commit 9041b53)
song-jiang
pushed a commit
to song-jiang/libcalico-go
that referenced
this pull request
Jul 13, 2021
Merge pull request projectcalico#1446 from song-jiang/song-fix-pod-termination (cherry picked from commit 9041b53)
This was referenced Jul 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes projectcalico/calico#4518 by reinstating
Fix that IsFinished wasn't checking whether the podIPs annotation was actually presentof #1397Todos
Release Note