This repository was archived by the owner on Oct 20, 2025. It is now read-only.
Fix handling of empty podIPs annotation#1397
Merged
Merged
Conversation
caseydavenport
approved these changes
Apr 6, 2021
caseydavenport
added a commit
that referenced
this pull request
Apr 8, 2021
…-#1397-origin-release-v3.18 Automated cherry pick of #1397: Fix handling of empty podIPs annotation
fasaxc
added a commit
that referenced
this pull request
Apr 21, 2021
marvin-tigera
added a commit
that referenced
this pull request
Apr 21, 2021
…rry-pick-of-#1397-origin-release-v3.18 Revert "Automated cherry pick of #1397: Fix handling of empty podIPs annotation"
3 tasks
|
why rollout restart sts can still see pod ip in annotation？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IsFinishedwasn't checking whether thepodIPsannotation was actually present. Since the zero value for a string is"", we need to check for presence too or we'll be confused for non-Calico CNIs that don't set the annotation.HasIPAddressandgetPodIPsdidn't honour the annotation.Todos
Release Note