Skip to content

Restore #4883#4891

Merged
SevInf merged 1 commit intomainfrom
feat/restore-json-noparse
May 29, 2024
Merged

Restore #4883#4891
SevInf merged 1 commit intomainfrom
feat/restore-json-noparse

Conversation

@SevInf
Copy link
Copy Markdown
Contributor

@SevInf SevInf commented May 28, 2024

This PR restores #4883 without any modifications.
Release pipeline is green again, so we should be ready to integrate it.
Original PR is work of @Druue, I am just a monkey pressing "revert"/"restore" buttons.

…ctly handle `i64`s (#4883)

* One half of the fix for: prisma/prisma#23926
* Unexcludes pg, neon, and PS for the through_relations::common_types test

* Instead of receiving pre-handled JSON by DAs, we now expect strings and will perform JSON parsing in Quaint.
* Removed special handling for "$__prisma_null" due to the aforementioned

* Temporarily disable wasm-benchmarks due to breaking change in engines <-> DA contract. To be re-enabled and re-evaluated in a follow-up PR per convo with @SevInf

---------

Co-authored-by: Serhii Tatarintsev <tatarintsev@prisma.io>
@SevInf SevInf requested a review from a team as a code owner May 28, 2024 12:52
@SevInf SevInf requested review from jkomyno and removed request for a team May 28, 2024 12:52
@SevInf SevInf added this to the 5.15.0 milestone May 28, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented May 28, 2024

CodSpeed Performance Report

Merging #4891 will not alter performance

Comparing feat/restore-json-noparse (9e8157b) with main (bca2d36)

Summary

✅ 11 untouched benchmarks

@github-actions
Copy link
Copy Markdown
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.041MiB 2.041MiB 380.000B
Postgres (gzip) 813.643KiB 813.273KiB 379.000B
Mysql 2.011MiB 2.011MiB 387.000B
Mysql (gzip) 800.059KiB 799.904KiB 159.000B
Sqlite 1.914MiB 1.914MiB 166.000B
Sqlite (gzip) 762.785KiB 762.655KiB 133.000B

@SevInf SevInf merged commit 64bb6b9 into main May 29, 2024
@SevInf SevInf deleted the feat/restore-json-noparse branch May 29, 2024 10:12
@SevInf
Copy link
Copy Markdown
Contributor Author

SevInf commented May 29, 2024

Merge with red tests is expected, we need prisma/prisma#24269 to be merged as well as a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants