fix(pg / neon/ PS): Do not parse JSON - send it directly to engines#24269
Merged
fix(pg / neon/ PS): Do not parse JSON - send it directly to engines#24269
Conversation
Contributor
size-limit report 📦
|
SevInf
reviewed
May 23, 2024
SevInf
approved these changes
May 24, 2024
Contributor
SevInf
left a comment
There was a problem hiding this comment.
LGTM, when engine update makes it into the repo and we see green tests
SevInf
added a commit
to prisma/prisma-engines
that referenced
this pull request
May 24, 2024
…an correctly handle `i64`s (#4883)" This reverts commit f742678. Temporary reverting the change. It is interdependent with prisma/prisma#24269 and neither PR works correctly without the other. The plan was to let engines CI to temporarily go red and fix it immediately by merging client PR. However, engine release pipeline is broken for unrelated reason and this is not possible. Just to limit amount of broken things in progress, we are reverting original PR. It is expected we restore it with no changes once release pipeline is fixed.
SevInf
added a commit
to prisma/prisma-engines
that referenced
this pull request
May 24, 2024
…an correctly handle `i64`s (#4883)" (#4886) This reverts commit f742678. Temporary reverting the change. It is interdependent with prisma/prisma#24269 and neither PR works correctly without the other. The plan was to let engines CI to temporarily go red and fix it immediately by merging client PR. However, engine release pipeline is broken for unrelated reason and this is not possible. Just to limit amount of broken things in progress, we are reverting original PR. It is expected we restore it with no changes once release pipeline is fixed.
f3019f5 to
f5ef2b4
Compare
This was referenced May 29, 2024
f5ef2b4 to
d0c7135
Compare
Contributor
|
Should be good to merge once green |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into an issue where the handling for JSON parsing was inconsistent for bigints nested inside of JSON relations:
This is the result of a native PG query. Note how the outer value is a string as expected but the inner is a number which would yield conversion errors
As we now send handle JSON parsing in engines, rust is fully capable of handling
i64values and can therefore parse it correctly leading to correct bigint valuesfix #23926
related prisma/prisma-engines#4883
Note to be aware of:
JSONbut do not allow for custom type parsing as PG, Neon, and PS do, we may run into issues