feat(sdk): load .env from project root by williamluke4 · Pull Request #3971 · prisma/prisma

williamluke4 · 2020-10-20T09:28:53Z

closes #3720

How it will work

Load .env from project root
Load first .env from possible schema locations and throw if there are env clashes with root .env
1. Read location from schema arg --schema
2. Read location from pkgJSON "prisma": {"schema": "/path/to/schema.prisma"}
3. Read from default location ./prisma/.env

TODO

src/packages/cli/src/__tests__/dotenv-1-custom-schema-path.test.ts

src/packages/cli/src/__tests__/dotenv-3-conflict.test.ts

src/packages/sdk/src/utils/loadEnv.ts

Jolg42 · 2020-10-21T09:47:14Z

I will need to play with it locally I think to get the full experience

src/packages/sdk/src/utils/loadEnv.ts

timsuchanek · 2020-10-21T13:41:36Z

Once this is green, we can merge :)

Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>

* master: feat(sdk): load .env from project root (#3971) chore: Integration/prisma/engines (#3942)

matthewmueller · 2020-10-27T10:56:59Z

src/packages/sdk/src/utils/loadEnv.ts

-
+/**
+ * Tries load env variables
+ *  1. Load .env from project root


The order in the code seems different? It seems like "Load .env from project root" happens last?

Yeah this needs to be updated I thought I had

matthewmueller · 2020-10-27T10:58:22Z

src/packages/sdk/src/utils/loadEnv.ts

+    schemaEnvPathFromArgs,        // 1 - Check --schema directory for .env
+    schemaEnvPathFromPkgJson,     // 2 - Check package.json schema directory for .env
+    './prisma/.env',              // 3 - Check ./prisma directory for .env
+    './.env'                      // 4 - Check cwd for .env


I might have missed something, but for 4, I think we'd want to check the same dir as where your package.json resides, rather than cwd.

The logic for loading the env var from your project root would cover that case.

https://github.com/prisma/prisma/pull/3971/files/f3af22fcacc7827d1c35688691d3c730f9c0ddfe#diff-59890438ec39361cbc9c8bf8a8772c311453c15035dd4e82351b04d70980fcf4R41

williamluke4 changed the title ~~feat(sdk): load .env from proect root~~ feat(sdk): load .env from project root Oct 20, 2020

williamluke4 force-pushed the feat/resolve-env-project-root branch 2 times, most recently from 378118b to 4727134 Compare October 20, 2020 14:19

williamluke4 added this to the Release 2.10.0 milestone Oct 20, 2020

Jolg42 self-requested a review October 20, 2020 16:14

williamluke4 requested a review from matthewmueller October 21, 2020 06:07

williamluke4 force-pushed the feat/resolve-env-project-root branch 2 times, most recently from 6d03e3b to 92a5c76 Compare October 21, 2020 08:13